Fix type definitions - #125
Merged
Merged
Conversation
perrinjerome
suggested changes
May 18, 2020
8 tasks
danixeee
suggested changes
May 20, 2020
danixeee
left a comment
danixeee
left a comment
Contributor
There was a problem hiding this comment.
@perrinjerome thanks for the help!
According to the specs, there are some new base types:
- WorkDoneProgressCreateParams
- WorkDoneProgressBegin
- WorkDoneProgressReport
- WorkDoneProgressEnd
- WorkDoneProgressCancelParams
- WorkDoneProgressParams
- WorkDoneProgressOptions
- PartialResultParams
So, HoverParams should extend WorkDoneProgressParams instead of adding a workDoneToken field. You do not have to add all of these types in this PR, maybe you can just remove self.workDoneToken = work_done_token from HoverParams and we can merge it.
danixeee
approved these changes
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
This commit
ClientInfotoInitializeParamsHoverParamsTextDocumentItemfromVersionedTextDocumentIdentifier__init__.Code review checklist (for code reviewer to complete)