Repository navigation
feat: remove previews - #491
Conversation
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This unfortunately removes all previews. A follow up is needed to add it from GraphQL |
|
@wolfy1339 do you think it's worth a revert of this PR in the meantime? I'm not sure I understand the scope of the issue. |
|
I don't think a revert is warranted here. We can probably handle it in the packages that have GraphQL themselves.
Types would need to be handled there |
|
It looks like this broke plugin-enterprise-server.js as well - I should've taken a closer look and remembered that there are still old supported versions of GHE that have references to previews. |
|
On the upside, GHE 3.2 (which had the majority of the preview implementation is deprecated: https://docs.github.com/en/enterprise-server@3.7/admin/all-releases I'll need to check 3.3 (set to deprecate next week 01.18.2023) and 3.4 to make sure they are all gone from GHE versions - if that's the case we can just drop support for those versions as well and not rollback. Thoughts? |
|
Update: Two instances have been left out in the REST API descriptions though they are defunct by v3.3. @wolfy1339 It looks like we have two options here:
Let me know your thoughts when you get the chance. Thanks! |
|
Sounds good |
This reverts commit cb0835b.
Followup to octokit/endpoint.js#382 (comment)
See also octokit/endpoint.js#388 octokit/core.js#538 octokit/plugin-paginate-rest.js#486
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance