How to control indents via param options to dump? #468

Activity

1. puzrin commented on Feb 18, 2019

   

   puzrin

   on Feb 18, 2019

   Member

   More actions

   https://github.com/nodeca/js-yaml#safedump-object---options-

   noArrayIndent ?
2. diberry commented on Feb 18, 2019

   

   diberry

   on Feb 18, 2019

   ContributorAuthor

   More actions

   Here are all my options, I toggled noArrayIndent and the results are in the screenshot. Left = original

   options={ "skipInvalid":false, "noCompatMode":false, "sortKeys":false, "lineWidth":3000, "noArrayIndent":false, "noRefs":true, "flowLevel":-1, "condenseFlow":false }

   
3. puzrin commented on Feb 18, 2019

   

   puzrin

   on Feb 18, 2019

   Member

   More actions

   Is this this a question or not? Is this issue solved?
4. perlpunk commented on Feb 18, 2019

   

   perlpunk

   on Feb 18, 2019

   More actions

   @diberry could you paste your results as text instead of a screenshot? just put three backticks in one line
   before and after the pasted snippet. or indent the whle snippet with 4 spaces. makes it easier to copy snippets and try them out.

   @puzrin it looks like a bug to me. in the picture on the right the YAML seems invalid. items like href: ... in line 2 and expanded: ... in line 4 have no indent
5. diberry commented on Feb 18, 2019

   

   diberry

   on Feb 18, 2019

   Last edited by diberry

   ContributorAuthor

   More actions

   @perlpunk Thanks for the pointer.
   @puzrin I think it is a bug - it I'm not as strict with Yaml as this library so I don't know if it is the library as a bug, the the library as intended behavior.

   original

   - name: LUIS Documentation
     href: index.yml
   - name: Overview
     expanded: true
     items:
     - name: C#
       href: https://cognitive.uservoice.com/knowledgebase/topics/asdfasdfasdfasdfasdfasdf/127872-luis-language-understanding-intelligent-service
   

   "noArrayIndent"= false

   - name: LUIS Documentation
     href: index.yml
   - name: Overview
     expanded: true
     items:
       - name: 'C#'
         href: 'https://cognitive.uservoice.com/knowledgebase/topics/asdfasdfasdfasdfasdfasdf/127872-luis-language-understanding-intelligent-service'
   

   "noArrayIndent"=true

   - name: LUIS Documentation
   href: index.yml
   - name: Overview
   expanded: true
   items:
   - name: 'C#'
     href: 'https://cognitive.uservoice.com/knowledgebase/topics/asdfasdfasdfasdfasdfasdf/127872-luis-language-understanding-intelligent-service'
   

   What I would like but not sure how to get it from .dump() - notice the same indent spacing as original.

   - name: LUIS Documentation
     href: index.yml
   - name: Overview
     expanded: true
     items:
     - name: 'C#'
       'href: https://cognitive.uservoice.com/knowledgebase/topics/asdfasdfasdfasdfasdfasdf/127872-luis-language-understanding-intelligent-service'
   
6. puzrin commented on Feb 18, 2019

   

   puzrin

   on Feb 18, 2019

   Member

   More actions

   That's certainly a bug, need fix. I've asked PR author. Or anyone else can do new PR.

   Seems happen when root is array (rare case, missed)
7. puzrin

   added

   bug

   on Feb 18, 2019
8. diberry commented on Feb 18, 2019

   

   diberry

   on Feb 18, 2019

   ContributorAuthor

   More actions

   @puzrin I would like to fix and PR.
9. puzrin commented on Feb 18, 2019

   

   puzrin

   on Feb 18, 2019

   Member

   More actions

   No problem. https://github.com/nodeca/js-yaml/pull/461/files - use this as example. If implementation will be correct, i'll approve & release asap.
10. puzrin

    added a commit that references this issue on Feb 26, 2019

    Fix for issue #468 includes passing test (#469)

    99c0bf9
11. puzrin

    closed this as completedon Feb 26, 2019