Final preparations for 3.4 - #548
Merged
Merged
Conversation
This scenario was missed.
To ensure we have the same behaviour and validations.
Avoiding unnecessary deprecation messages.
Since PHP 5.6 is our minimum version this can be safely dropped.
This array manipulation is just unnecessary now.
lcobucci
force-pushed
the
final-preparations-for-3.4
branch
from
November 25, 2020 01:12
3ddd302 to
5d1dcb1
Compare
This was
linked to
issues
Nov 25, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #511
Fix #537