Skip to content

Bypass hosts not used on HTTPSConnectionWithTimeout #160

Description

@joaomsan

Hello,

I was investigating why a https request that i was doing was using proxy even though i added the host to bypass_hosts.

I found out the the method HTTPConnectionWithTimeout.connect does the following

line 1155 if self.proxy_info and self.proxy_info.isgood() and self.proxy_info.applies_to(self.host):

But the method HTTPSConnectionWithTimeout.connect does the following
line 1287 if self.proxy_info and self.proxy_info.isgood():

I think that the https connections are missing the .applies_to

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions