Repository navigation
baseline changes to help (JRuby) development - #371
Merged
Merged
Conversation
JRuby 1.7 was Java6+ compatible (9.2 is Java8+)
kares
changed the title
Contributor
Author
Contributor
Author
Contributor
Author
|
... could we get this in that here, for future json work or do we have to do smt differently? |
olleolleolle
approved these changes
Jun 25, 2020
olleolleolle
left a comment
olleolleolle
left a comment
Contributor
There was a problem hiding this comment.
These changes make JRuby builds possible and more practical! LGTM!
Contributor
|
Sorry this flew under my radar. The changes look fine. |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Open
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these were originally part of #361
the most relevant change is that we weren't able to run tasks
test_pureandtest_extas intended.... one needed to do:
env JSON=pure bundle exec rake test_pure