Repository navigation
vec::IntoIter fixes - #181
Merged
Merged
Conversation
IntoIter was missing a 'borrow lifetime parameter, leading to trivial use-after-free issues (fixes fitzgen#187).
Both Vec and Drain drop leftover elements when they are dropped. It would be inconsistent for IntoIter to just leak them.
Contributor
|
This fixes #178. |
fitzgen
reviewed
Oct 14, 2022
fitzgen
left a comment
fitzgen
left a comment
Owner
There was a problem hiding this comment.
Thanks! One comment to be addressed before this can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into these issues while tracking down a memory leak.