Add compliance mode for LEGACY multipart parser in Jetty 10+ - #8008
Merged
lachlan-roberts merged 3 commits intoMay 26, 2022
Merged
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
added
the
Sponsored
gregw
requested changes
May 24, 2022
gregw
left a comment
gregw
left a comment
Contributor
There was a problem hiding this comment.
If we need this legacy mode going forward, then I don't think it is viable to continue with 2 different parsers. We will need to work out how to make the one parser handle the different line terminations
gregw
previously approved these changes
May 24, 2022
gregw
left a comment
gregw
left a comment
Contributor
There was a problem hiding this comment.
I am provisionally approving this just to solve the short term problem......
BUT this should not be merged forward to jetty-12 (well do the merge, but then revert the code). In 12, we need to go to fully asynchronous multipart parsing and it will be unsustainable to have 2 parsers to be so maintained.
So keep the issue open and let's solve it properly in 12.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…legacyMultipartParser
gregw
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce multipart
RFC7578/LEGACYcompliance modes to Jetty 10 with a default ofRFC7578.This allows an option to revert to the less efficient decoding of the LEGACY decoder which allows deprecated line terminations and decodes parts with the deprecated
Content-Transfer-Encoding.