Skip to content

ClientCertAuthenticator is not taking account SslContext configuration #5933

Closed
#5934
Closed
ClientCertAuthenticator is not taking account SslContext configuration#5933
#5934

Description

@olamy
olamy
opened on Feb 1, 2021

Jetty version
10.0.x (but might a 9.4.x issue as well)

Description
Using CLIENT-CERT as login with a configured trustStore via ssl.ini.

  <login-config>
    <auth-method>CLIENT-CERT</auth-method>
  </login-config>

The used ClientCertAuthenticator instance is not using the configuration from the instance SslContextFactory instance.

Activity

  1. sbordet commented on Feb 1, 2021

    @sbordet
    sbordet
    on Feb 1, 2021
    Contributor

    @lachlan-roberts do you want to tackle this?

    Ideally, web applications that need this kind of authentication will need to setup a custom Jetty context XML file, where the configure the authenticator.

    However, we want to have a good default if that custom XML is not there.

    The idea is that, in DefaultAuthenticatorFactory.getAuthenticator(...) we create a ClientCertAuthenticator passing to the constructor the SslContextFactory.Server that we extract from the Server parameter.

    If there is more than 1 SslContextFactory.Server, do nothing; otherwise pass it to ClientCertAuthenticator.

  2. olamy
    added 2 commits that reference this issue on Feb 2, 2021

    Issue #5933 ClientCertAuthenticator is not using SslContextFactory fr…

    4051b63

    Issue #5933 ClientCertAuthenticator is not using SslContextFactory fr…

    32672d4
  3. gregw
    linked a pull request that will close this issueIssue #5933 ClientCertAuthenticator is not using SslContextFactory from server #5934on Feb 8, 2021
  4. gregw
    added a commit that references this issue on Feb 9, 2021

    Issue #5933 ClientCertAuthenticator is not using SslContextFactory

    f2c9056
  5. olamy
    closed this as completedin #5934on Feb 10, 2021
  6. olamy
    added a commit that references this issue on Feb 10, 2021

    Issue #5933 ClientCertAuthenticator is not using SslContextFactory (#…

    68790d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions