Repository navigation
Remove redundant NuGet package references. - #1849
Merged
Merged
Conversation
Contributor
Author
|
Overlaps with #1536; this one is simpler and more targeted. |
Codecov ReportBase: 70.19% // Head: 69.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 70.19% 69.20% -1.00%
==========================================
Files 292 292
Lines 61727 61727
==========================================
- Hits 43331 42718 -613
- Misses 18396 19009 +613
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
DavoudEshtehari
approved these changes
Jan 12, 2023
lcheunglci
approved these changes
Jan 12, 2023
lcheunglci
left a comment
lcheunglci
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for your contributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes dependencies to NuGet packages that are not needed for each framework we target. Some packages are useless for anything other than .NET Standard 1.x and cause an explosion of transitive dependencies (such as
System.IO), others provide functionality that became inbox in newer frameworks (such asSystem.Buffersfor .NET Standard 2.1 and .NET 6, orMicrosoft.Win32.Registryfor .NET 6), and others were unused (such asSystem.Security.Cryptography.Algorithmswhich providesIncrementalHashon older .NET Framework versions which is not used by this library).I didn't change any executable code, if CI passes it should be OK. Let's see if I missed anything.
Fixes NuGet/Home#12240.