Repository navigation
Adding TDS8 version for TDSLogin - #1657
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1657 +/- ##
==========================================
- Coverage 71.39% 71.32% -0.07%
==========================================
Files 293 293
Lines 61368 61382 +14
==========================================
- Hits 43812 43783 -29
- Misses 17556 17599 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
David-Engel
reviewed
Jun 21, 2022
David-Engel
left a comment
David-Engel
left a comment
Contributor
There was a problem hiding this comment.
Don't we also send the version in LOGIN7 (TdsLogin() method)?
David-Engel
reviewed
Jun 27, 2022
David-Engel
approved these changes
Jun 30, 2022
Contributor
Author
|
Just a note that the minor version 0x0005 for SQL server 2022 would be changed to 0 in the next release SQL2022. |
David-Engel
approved these changes
Jul 21, 2022
Contributor
Author
|
for those who are going to test. Please use below query to see related fields. elect
ec.connect_time,es.last_request_start_time ,es.session_id,
(CAST(protocol_version AS BINARY(4))),
es.program_name, es.client_version, ec.protocol_type,ec.protocol_version,
es.client_interface_name,ec.encrypt_option
from sys.dm_exec_sessions as es
inner join sys.dm_exec_connections as ec
on ec.session_id = es.session_id |
David-Engel
approved these changes
Jul 22, 2022
DavoudEshtehari
approved these changes
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is addressing TDS8 issue with TDS Login version.
fixes #1652