Repository navigation
deps: bump json5 to use type definition provided officially - #158
Merged
Merged
Conversation
Owner
|
Thanks! |
Contributor
Author
|
Thank you! |
|
See #171 - this is indeed a breaking change published in a minor version, because json5 v2 breaks on node 4. |
Owner
|
@ljharb Good catch, I'll revert this PR then. |
jonaskello
added a commit
that referenced
this pull request
Aug 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json5has provided its type definition from v2.2.0, so@types/json5has been deprecated.https://github.com/json5/json5/releases/tag/v2.2.0
json5has dropped Node v4 support at v2, so iftsconfig-pathssupports the version, this would be a breaking change.Thanks!