Skip to content

Testing and cleanup of transformResponse - #3377

Merged
jasonsaayman merged 5 commits into
axios:masterfrom
timemachine3030:bugfix/3374-try-two
Mar 24, 2021
Merged

jasonsaayman merged 5 commits into
axios:masterfrom
timemachine3030:bugfix/3374-try-two

Conversation

@timemachine3030

Copy link
Copy Markdown
Contributor

Fixes #3374, including my own cleanup.

  • Tests for transformResponse
  • Remove eslint error by renaming the var
  • Test the data a length to avoid JSON.parse headache
  • Use util.isString() over typeof

timemachine3030 and others added 2 commits November 1, 2020 00:42
 - Tests for transformResponse
 - Remove eslint error by renaming the var
 - Test that there data a length to avoid JSON.parse headache
 - Use `util.isString()` over `typeof`
@jasonsaayman jasonsaayman self-assigned this Dec 9, 2020
@jasonsaayman jasonsaayman modified the milestones: v0.21.1, v0.22.0 Dec 9, 2020

@jasonsaayman jasonsaayman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not apply data tansformation to the empty 204 status code responses

2 participants