Repository navigation
Add Smartsheet as a provider. - #741
Conversation
martincostello
left a comment
martincostello
left a comment
There was a problem hiding this comment.
Can you add the new provider to the table in the README please? There's a template row you can copy in a comment at the bottom.
…ptions.cs Co-authored-by: Martin Costello <martin@martincostello.com>
…rtsheet.csproj Co-authored-by: Martin Costello <martin@martincostello.com>
…ageId may not included in the UserInformationEndpoint response.
…Steve/AspNet.Security.OAuth.Providers into feature/add-smartsheet # Conflicts: # src/AspNet.Security.OAuth.Smartsheet/SmartsheetAuthenticationOptions.cs
|
Thanks for your contribution, this looks good. Can you confirm that you've tested this provider with the real SmartSheet service and that it works as intended with a running application? |
|
I use a couple of other providers in the same project I'm writing this provider for, so it's nice to be able to give back! I was able to sign in with the provider and also view the sheets, as expected, so it is works as intended. |
|
Awesome - thanks. I'll look at merging this PR and getting the new provider published to NuGet.org later on today. |
|
Thanks again for your contribution - the new provider is now available from NuGet.org: https://www.nuget.org/packages/AspNet.Security.OAuth.Smartsheet/ |
|
That's great, thanks! |
Add an OAuth 2.0 Smartsheet provider. https://www.smartsheet.com/