Skip to content

core: add helpers for working with paths across OSes - #1102

Merged
thboop merged 1 commit into
actions:mainfrom
sethvargo:sethvargo/path
Jun 15, 2022
Merged

core: add helpers for working with paths across OSes#1102
thboop merged 1 commit into
actions:mainfrom
sethvargo:sethvargo/path

Conversation

@sethvargo

@sethvargo sethvargo commented May 26, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@sethvargo
sethvargo requested a review from a team as a code owner May 26, 2022 16:17
@sethvargo

sethvargo commented May 26, 2022

Copy link
Copy Markdown
Contributor Author

/cc @jmillsy @konradpabjan @thboop

konradpabjan
konradpabjan reviewed May 26, 2022
View reviewed changes

@konradpabjan konradpabjan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great!

Could you go ahead and document these new functions in the README for @actions/core: https://github.com/actions/toolkit/tree/main/packages/core

@sethvargo

sethvargo commented May 26, 2022

Copy link
Copy Markdown
Contributor Author

@konradpabjan done

konradpabjan
konradpabjan approved these changes May 31, 2022
View reviewed changes

@konradpabjan konradpabjan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'll differ for the final approval from @thboop before merging in

thboop
thboop approved these changes Jun 15, 2022
View reviewed changes

@thboop thboop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@thboop
thboop merged commit 00282d6 into actions:main Jun 15, 2022
@sethvargo
sethvargo deleted the sethvargo/path branch June 15, 2022 17:50
@RA80533

RA80533 commented Jun 20, 2022 •
edited
Loading

Copy link
Copy Markdown

I was wondering what the purpose of these functions was compared to those from the native Path module (link). I figured it was discussed offline since it wasn't in the PR description.

I'd love to understand so I can have a better idea of when they're recommended. Thanks!

@sethvargo

sethvargo commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

Hi @RA80533 these functions are for converting from platform-specific or non-platform-specific paths, regardless of the underlying operating system.

@warnyul warnyul mentioned this pull request Jan 30, 2023
Merged
@Graysonbarton Graysonbarton mentioned this pull request May 11, 2024
Open
Derrick-MUGISHA pushed a commit to Derrick-MUGISHA/toolkit that referenced this pull request Oct 12, 2026
@sethvargo
core: add helpers for working with paths across OSes (actions#1102)
bb84db6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thboop thboop thboop approved these changes
+1 more reviewer
@konradpabjan konradpabjan konradpabjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sethvargo @RA80533 @konradpabjan @thboop