Skip to content

Don't process a stale issue in the same run it's marked stale - #696

Merged
luketomlinson merged 1 commit into
mainfrom
bugfix/stale-mutually-exclusive
Apr 29, 2022
Merged

luketomlinson merged 1 commit into
mainfrom
bugfix/stale-mutually-exclusive

Conversation

@luketomlinson

Copy link
Copy Markdown
Collaborator

Changes

We don't want to check for comments/updates if the issue/PR was just marked stale that run.

  • ...

Context

fixes #690

@luketomlinson
luketomlinson requested a review from a team as a code owner March 17, 2022 13:41
@github-actions github-actions Bot added the Stale label Apr 17, 2022
@github-actions github-actions Bot closed this Apr 22, 2022
@luketomlinson luketomlinson reopened this Apr 22, 2022
@github-actions github-actions Bot closed this Apr 28, 2022
@luketomlinson luketomlinson reopened this Apr 28, 2022

// Should we un-stale this issue?
if (shouldRemoveStaleWhenUpdated && issueHasComments) {
if (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we could just else if here and remove !issue.markedStaleThisRun

@thboop thboop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luketomlinson
luketomlinson merged commit 65d24b7 into main Apr 29, 2022
@luketomlinson
luketomlinson deleted the bugfix/stale-mutually-exclusive branch April 29, 2022 14:07
@Gustry

Gustry commented May 20, 2022

Copy link
Copy Markdown

Thanks for this fix. Is-it possible to make a release ?

@Ryan9Manu

Copy link
Copy Markdown

Jighbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale action erroneously removed the stale label

4 participants