Skip to content

Previously fixed bug was reintroduced #8173

Closed
Closed
Previously fixed bug was reintroduced#8173
Labels
confirmed-bugWe've confirmed this is a bug in Mongoose and will fix it.
Milestone
5.7.3

Description

@jimmytsao
jimmytsao
opened on Sep 17, 2019

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
A previously reported bug was fixed in version 5.1.3 of mongoose. Starting with version 5.2.5, the bug has been reintroduced.

Previously fixed bug: #6488

If the current behavior is a bug, please provide the steps to reproduce.

See the reproduction script in the link above under the section:

Virtual Population NOT WORKING When Virtual Field Is Nested Within Embedded Object Schema

What is the expected behavior?
I expected the issue to be resolved in all versions after 5.1.3

What are the versions of Node.js, Mongoose and MongoDB you are using? Note that "latest" is not a version.
mongoose: 5.7.1
node: 10.14.1
mongo: 3.6.4

Activity

  1. vkarpov15
    added this to the 5.7.3 milestone on Sep 23, 2019
  2. vkarpov15
    added
    has repro scriptThere is a repro script, the Mongoose devs need to confirm that it reproduces the issue
    on Sep 23, 2019
  3. vkarpov15
    added a commit that references this issue on Sep 24, 2019

    test(populate): repro #8173 #6488

    b42d0f5
  4. vkarpov15
    closed this as completedin 0a33412on Sep 24, 2019

  5. vkarpov15 commented on Sep 24, 2019

    @vkarpov15
    vkarpov15
    on Sep 24, 2019
    Collaborator

    Sorry for the trouble, it looks like our test case for #6488 didn't test the full integration, just tested a unit that happened to cause this issue in 2018. We added a full integration test for this issue, so virtual populate on a nested schema within an embedded discriminator should work fine going forward as of 5.7.3 👍

  6. vkarpov15
    added
    confirmed-bugWe've confirmed this is a bug in Mongoose and will fix it.
    and removed
    has repro scriptThere is a repro script, the Mongoose devs need to confirm that it reproduces the issue
    on Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugWe've confirmed this is a bug in Mongoose and will fix it.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions