Repository navigation
parsermodule and grammar variable #48538
Description
| BPO | 4288 |
|---|---|
| Nosy | @loewis, @msapiro, @tiran |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2009-01-11.09:35:19.327>
created_at = <Date 2008-11-09.12:34:28.879>
labels = ['build', 'tests', 'OS-windows']
title = 'parsermodule and grammar variable'
updated_at = <Date 2009-01-11.09:35:19.326>
user = 'https://bugs.python.org/rpetrov'bugs.python.org fields:
activity = <Date 2009-01-11.09:35:19.326>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2009-01-11.09:35:19.327>
closer = 'loewis'
components = ['Build', 'Tests', 'Windows']
creation = <Date 2008-11-09.12:34:28.879>
creator = 'rpetrov'
dependencies = []
files = ['11969']
hgrepos = []
issue_num = 4288
keywords = ['patch']
message_count = 8.0
messages = ['75652', '75657', '75658', '75659', '75660', '75661', '75662', '79593']
nosy_count = 5.0
nosy_names = ['loewis', 'msapiro', 'christian.heimes', 'kirkshorts', 'rpetrov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = '4279'
type = 'compile error'
url = 'https://bugs.python.org/issue4288'
versions = ['Python 2.6', 'Python 3.0']
Activity
rpetrov commentedon Nov 9, 2008
After synchronization of my mingw32 cross-compilation environment with
trunk some of tests fail. The reason is that parsermodule fail to link.
Please check build on officially supported platform: MSVC and cygwin.
The attached patch (parser-grammar.patch) solve issue in my environment.
tiran commentedon Nov 9, 2008
As far as I know neither cygwin nor MinGW32 are falling under the
categoy of first class citizens. MinGW32 is only officially supported to
build extension modules. The compilers aren't used by our build bots, too.
In order to make both cygwin builds and MinGW32 compiler major platforms
somebody has to step up and constantly provides testing and patches.
kirkshorts commentedon Nov 9, 2008
looks like it might be a similar root issue to the one I raised in bpo-4279.
Looks like this patch breaks the data hiding that I think has been
attempted :-( though it doesn't mess with setup.py in the way mine does :-)
Don't know how Christian's comment affects either of our patches though
(still an uber newbie to the whole contributing to Python thing ;-) )
tiran commentedon Nov 9, 2008
Andy:
Of course we like to support Cygwin and MinGW32. I wanted to make clear
that the platforms aren't top priority. They aren't regularly tested by
any of the core developers and build bots.
Regarding data hiding, you are correct. I'm more fond of your solution bpo-4279
tiran commentedon Nov 9, 2008
Oh, I retract everything I said about your patch. I didn't read your
patch carefully enough. With your patch the parser module wouldn't use
the same grammer as the rest of Python. That might be an issue.
kirkshorts commentedon Nov 9, 2008
Christian:
Cool, thanks for the feedback d00d - it took longer than i though to get
what I predicted :-) No worries on the whole "core target" platform
thing - I understand it perfectly, had the same issue for work related
things: too many platform and too few test resources :-( And sadly I am
in not a position to gift any to the cause - sorry.
Can I ask how it would mean that parser would get a different grammar?
In the interests of a newbie learning if you don't mind (maybe post the
reply to bpo-4279 as I guess it is more relevant there than here)
kirkshorts commentedon Nov 9, 2008
Christian: sorry my 'find' kung fu is weak :-( :-$ I see why.
Will work on a better patch.
loewis commentedon Jan 11, 2009
This is now fixed with the resolution to bpo-4279.