Extract next-swc Rust code into its own package - #31635
Merged
Merged
Conversation
padmaia
commented
Nov 19, 2021
padmaia
force-pushed
the
chore/next-swc-package
branch
3 times, most recently
from
November 20, 2021 00:17
0afe83c to
850a244
Compare
padmaia
force-pushed
the
chore/next-swc-package
branch
from
November 20, 2021 00:24
850a244 to
e08b92a
Compare
Member
Author
|
I believe the failing tests will not fail once this is merged into the canary branch. @ijjk can you confirm? |
padmaia
marked this pull request as ready for review
November 20, 2021 01:05
padmaia
requested review from
huozhi,
ijjk,
shuding,
styfle and
timneutkens
as code owners
November 20, 2021 01:05
This comment has been minimized.
This comment has been minimized.
ijjk
reviewed
Nov 20, 2021
ijjk
left a comment
ijjk
left a comment
Member
There was a problem hiding this comment.
Updated to ensure the binary is handled for isolated tests/PR stats. Looks good to land if the changes look alright to you 👍
…nto chore/next-swc-package
ijjk
added
create-next-app
This comment has been minimized.
This comment has been minimized.
timneutkens
previously approved these changes
Nov 21, 2021
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| buildDuration | 17.9s | 18.1s | |
| buildDurationCached | 3.6s | 3.6s | -17ms |
| nodeModulesSize | 339 MB | 339 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.982 | 3.037 | |
| / avg req/sec | 838.24 | 823.1 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.404 | 1.343 | -0.06 |
| /error-in-render avg req/sec | 1780.2 | 1861.02 | +80.82 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 28.4 kB | 28.4 kB | ✓ |
| webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
| Overall change | 72.2 kB | 72.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 327 B | 327 B | ✓ |
| dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 635 B | 635 B | ✓ |
| image-HASH.js gzip | 4.45 kB | 4.45 kB | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 1.87 kB | 1.87 kB | ✓ |
| routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
| script-HASH.js gzip | 383 B | 383 B | ✓ |
| withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 13.3 kB | 13.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 460 B | 460 B | ✓ |
| Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 545 B | 545 B | ✓ |
| withRouter.html gzip | 527 B | 527 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| buildDuration | 19.5s | 19.6s | |
| buildDurationCached | 3.6s | 3.6s | -71ms |
| nodeModulesSize | 339 MB | 339 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.986 | 2.962 | -0.02 |
| / avg req/sec | 837.24 | 844.13 | +6.89 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.374 | 1.38 | |
| /error-in-render avg req/sec | 1819.24 | 1811.23 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
| main-HASH.js gzip | 28.6 kB | 28.6 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 72.5 kB | 72.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 305 B | 305 B | ✓ |
| css-HASH.js gzip | 321 B | 321 B | ✓ |
| dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
| head-HASH.js gzip | 342 B | 342 B | ✓ |
| hooks-HASH.js gzip | 622 B | 622 B | ✓ |
| image-HASH.js gzip | 4.47 kB | 4.47 kB | ✓ |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 1.91 kB | 1.91 kB | ✓ |
| routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
| script-HASH.js gzip | 375 B | 375 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 13.2 kB | 13.2 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | padmaia/next.js chore/next-swc-package | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 545 B | 545 B | ✓ |
| withRouter.html gzip | 526 B | 526 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
timneutkens
approved these changes
Nov 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract rust code into its own package so that we can have more granular caching.
Related: #31464